Skip to content

Collect logs with greater determination #2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlanCoding merged 1 commit into from
Nov 4, 2025
Merged

Collect logs with greater determination #2087

AlanCoding merged 1 commit into from
Nov 4, 2025

Conversation

@AlanCoding
Copy link
Member

@AlanCoding AlanCoding commented Nov 4, 2025

SUMMARY

we saw a 500 error from web but didn't get traceback which should be in stdout.

This presumably fixes that, as current code seems to give up when it doesn't see a container

2025-11-04T13:16:08.9157852Z TASK [Get all container log in pod] ********************************************
2025-11-04T13:16:09.7736840Z [ERROR]: Task failed: Module failed: Unable to retrieve log from Pod due to: container "example-awx-ee" in pod "example-awx-task-6dbd9bc5dd-pk49f" is waiting to start: PodInitializing
2025-11-04T13:16:09.7738474Z Origin: /home/runner/work/awx/awx/awx-operator/molecule/default/utils/output_all_container_logs_for_pod.yml:2:3
2025-11-04T13:16:09.7739173Z 
2025-11-04T13:16:09.7740601Z 1 ---
2025-11-04T13:16:09.7742062Z 2 - name: Get all container log in pod
2025-11-04T13:16:09.7743497Z     ^ column 3
2025-11-04T13:16:09.7744804Z 
2025-11-04T13:16:09.7748606Z fatal: [localhost]: FAILED! => {"changed": false, "msg": "Unable to retrieve log from Pod due to: container \"example-awx-ee\" in pod \"example-awx-task-6dbd9bc5dd-pk49f\" is waiting to start: PodInitializing"}
2025-11-04T13:16:09.7749379Z

You can kind of see here how it panics when a single container doesn't exist, and playbook ends. This is all fine when all tests pass, but almost certainly wrong in error cases.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change

djulich
djulich approved these changes Nov 4, 2025
View reviewed changes
Copy link

@djulich djulich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the pr title

@AlanCoding
Copy link
Member Author

AlanCoding commented Nov 4, 2025

reference ansible/awx#16154

@AlanCoding AlanCoding merged commit 605b46d into ansible:devel Nov 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thedoubl3j thedoubl3j thedoubl3j approved these changes

@djulich djulich djulich approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlanCoding @thedoubl3j @djulich